Closed
Bug 648885
Opened 14 years ago
Closed 14 years ago
Remove nsIImageFrame
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: khuey, Assigned: craig.topper)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 3 obsolete files)
|
3.83 KB,
patch
|
craig.topper
:
review+
|
Details | Diff | Splinter Review |
|
10.67 KB,
patch
|
craig.topper
:
review+
|
Details | Diff | Splinter Review |
|
9.93 KB,
patch
|
craig.topper
:
review+
|
Details | Diff | Splinter Review |
nsIImageFrame can be removed. http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsIImageFrame.h
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•14 years ago
|
||
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #529006 -
Flags: review?(roc)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #529007 -
Flags: review?(roc)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #529008 -
Flags: review?(roc)
Comment on attachment 529006 [details] [diff] [review]
Part 1: Remove 'using namespace' from nsImageFrame.h
Review of attachment 529006 [details] [diff] [review]:
::: layout/generic/nsImageFrame.h
@@ +186,5 @@
virtual void AddInlineMinWidth(nsRenderingContext *aRenderingContext,
InlineMinWidthData *aData);
+ nsRefPtr<mozilla::layers::ImageContainer> GetContainer(mozilla::layers::LayerManager* aManager,
+ imgIContainer* aImage);
Add "typedef mozilla::layers::ImageContainer ImageContainer;" etc to nsImageFrame to avoid cluttering the code with prefixes.
Attachment #529006 -
Flags: review?(roc) → review+
Comment on attachment 529007 [details] [diff] [review]
Part 2: Remove nsIImageFrame
Review of attachment 529007 [details] [diff] [review]:
Attachment #529007 -
Flags: review?(roc) → review+
Comment on attachment 529008 [details] [diff] [review]
Part 3: Remove nsIImageMap
Review of attachment 529008 [details] [diff] [review]:
::: accessible/src/html/nsHTMLImageMapAccessible.cpp
@@ +204,5 @@
nsIFrame *frame = GetFrame();
NS_ENSURE_TRUE(frame, NS_ERROR_FAILURE);
nsImageFrame *imageFrame = do_QueryFrame(frame);
+ nsRefPtr<nsImageMap> map = imageFrame->GetImageMap(presContext);
I think 'map' doesn't need to be an nsRefPtr, it can just be a raw ptr.
Attachment #529008 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 7•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #529006 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #529007 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 9•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #529008 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → craig.topper
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 10•14 years ago
|
||
Comment on attachment 529030 [details] [diff] [review]
Part 1: Remove 'using namespace' from nsImageFrame.h
Carry forward r+
Attachment #529030 -
Flags: review+
|
|
Assignee | |
Comment 11•14 years ago
|
||
Comment on attachment 529032 [details] [diff] [review]
Part 2: Remove nsIImageFrame
Carry forward r+
Attachment #529032 -
Flags: review+
|
|
Assignee | |
Comment 12•14 years ago
|
||
Comment on attachment 529033 [details] [diff] [review]
Part 3: Remove nsIImageMap
Carry forward r+
Attachment #529033 -
Flags: review+
|
|
Assignee | |
Comment 13•14 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•